Tilt metrics fix + docs update #308

hrak · 2023-09-01T08:01:33Z

Issue #, if available:

Description of changes:

This PR fixes an issue of CAPC failing to start with the following error due to double injection of prometheus metrics settings (this is taken care of by tilt-prepare now)

Build Failed: Deployment.apps "capc-controller-manager" is invalid: spec.template.spec.containers[0].ports[2].name: Duplicate value: "metrics"

It also updates the tilt docs to remove old info regarding credentials, and adds an example on how to enable a CAPI feature gate.

Testing performed:

make tilt-up successfully starts CAPC.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

k8s-ci-robot · 2023-09-01T08:01:42Z

Hi @hrak. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

netlify · 2023-09-01T08:02:33Z

✅ Deploy Preview for kubernetes-sigs-cluster-api-cloudstack ready!

Name	Link
🔨 Latest commit	`6009a1c`
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-cluster-api-cloudstack/deploys/656096d4f27aaf0008f83047
😎 Deploy Preview	https://deploy-preview-308--kubernetes-sigs-cluster-api-cloudstack.netlify.app/print
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

rohityadavcloud · 2023-09-20T06:17:52Z

/approve
/run-e2e

blueorangutan · 2023-09-20T06:18:03Z

@rohityadavcloud a jenkins job has been kicked to run test with following paramaters:

kubernetes version: 1.27.2
CloudStack version:
hypervisor: kvm
template: ubuntu-2004-kube
Kubernetes upgrade from: 1.26.5 to 1.27.2

codecov-commenter · 2023-09-20T06:26:36Z

Codecov Report

Patch and project coverage have no change.

Comparison is base (a2e323a) 25.47% compared to head (6fa985f) 25.47%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #308   +/-   ##
=======================================
  Coverage   25.47%   25.47%           
=======================================
  Files          59       59           
  Lines        5554     5554           
=======================================
  Hits         1415     1415           
  Misses       4000     4000           
  Partials      139      139

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

blueorangutan · 2023-10-01T08:59:04Z

Setting up environment failed

hrak · 2023-10-02T08:32:09Z

Setting up environment failed

Can someone please check this bot?

vishesh92 · 2023-10-10T06:20:08Z

/run-e2e -c 4.18

blueorangutan · 2023-10-10T06:21:02Z

@vishesh92 a jenkins job has been kicked to run test with following paramaters:

kubernetes version: 1.27.2
CloudStack version: 4.18
hypervisor: kvm
template: ubuntu-2004-kube
Kubernetes upgrade from: 1.26.5 to 1.27.2

vishesh92 · 2023-10-10T06:24:01Z

/approve

k8s-ci-robot · 2023-10-10T06:24:09Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hrak, rohityadavcloud, vishesh92

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [rohityadavcloud,vishesh92]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

config/default/kustomization.yaml

hrak · 2023-10-12T12:59:59Z

Just pushed a small additional change that allows Tilt and e2e tests to replace the metrics listen address (and removes a hack that made this work in e2e before)

related: kubernetes-sigs/cluster-api@7768a6d#diff-df1234d6ebfa1846a2bace68630ce653b3402bd4388aa4b0b8fb724df34b4af7

This is done by cluster-api tilt-prepare now Signed-off-by: Hans Rakers <[email protected]>

+ add feature gate example Signed-off-by: Hans Rakers <[email protected]>

Signed-off-by: Hans Rakers <[email protected]>

weizhouapache · 2023-12-06T13:15:01Z

/run-e2e -c 4.18

blueorangutan · 2023-12-06T13:16:04Z

@weizhouapache a jenkins job has been kicked to run test with following paramaters:

kubernetes version: 1.27.2
CloudStack version: 4.18
hypervisor: kvm
template: ubuntu-2004-kube
Kubernetes upgrade from: 1.26.5 to 1.27.2

rohityadavcloud · 2024-01-03T06:55:34Z

/run-e2e -c 4.18

blueorangutan · 2024-01-03T06:56:07Z

@rohityadavcloud a jenkins job has been kicked to run test with following paramaters:

kubernetes version: 1.27.2
CloudStack version: 4.18
hypervisor: kvm
template: ubuntu-2004-kube
Kubernetes upgrade from: 1.26.5 to 1.27.2

rohityadavcloud · 2024-03-22T10:32:07Z

/ok-to-test

docs/book/src/development/tilt.md

weizhouapache · 2024-05-28T12:43:31Z

/run-e2e -c 4.19

blueorangutan · 2024-05-28T12:44:03Z

@weizhouapache a jenkins job has been kicked to run test with following paramaters:

kubernetes version: 1.27.2
CloudStack version: 4.19
hypervisor: kvm
template: ubuntu-2004-kube
Kubernetes upgrade from: 1.26.5 to 1.27.2

vishesh92 · 2024-06-06T12:39:05Z

/run-e2e -c 4.19

blueorangutan · 2024-06-06T12:40:03Z

@vishesh92 a jenkins job has been kicked to run test with following paramaters:

kubernetes version: 1.27.2
CloudStack version: 4.19
hypervisor: kvm
template: ubuntu-2004-kube
Kubernetes upgrade from: 1.26.5 to 1.27.2

blueorangutan · 2024-06-06T16:36:57Z

Test Results : (tid-485)
Environment: kvm Rocky8(x3), Advanced Networking with Management Server Rocky8
Kubernetes Version: v1.27.2
Kubernetes Version upgrade from: v1.26.5
Kubernetes Version upgrade to: v1.27.2
CloudStack Version: 4.19
Template: ubuntu-2004-kube
E2E Test Run Logs: https://github.com/blueorangutan/capc-prs/releases/download/capc-pr-ci-cd/capc-e2e-artifacts-pr308-sl-485.zip



Summarizing 4 Failures:
 [FAIL] When testing Kubernetes version upgrades [It] Should successfully upgrade kubernetes versions when there is a change in relevant fields
 /root/go/pkg/mod/sigs.k8s.io/cluster-api/[email protected]/framework/machinedeployment_helpers.go:127
 [FAIL] When testing project [AfterEach] Should create a cluster in a project
 /jenkins/workspace/capc-e2e-new/test/e2e/project.go:103
 [FAIL] When testing node drain timeout [It] A node should be forcefully removed if it cannot be drained in time
 /root/go/pkg/mod/sigs.k8s.io/cluster-api/[email protected]/framework/deployment_helpers.go:88
 [TIMEDOUT] When testing with custom disk offering [It] Should successfully create a cluster with a custom disk offering
 /jenkins/workspace/capc-e2e-new/test/e2e/custom_disk_offering.go:61

Ran 27 of 30 Specs in 10816.759 seconds
FAIL! - Suite Timeout Elapsed -- 23 Passed | 4 Failed | 0 Pending | 3 Skipped
--- FAIL: TestE2E (10816.76s)
FAIL

vishesh92 · 2024-06-06T20:22:57Z

/lgtm

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 1, 2023

k8s-ci-robot requested review from dims and vishesh92 September 1, 2023 08:01

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 1, 2023

k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 1, 2023

hrak force-pushed the tilt_metrics_fix branch from 54b78dd to 6fa985f Compare September 1, 2023 08:03

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 20, 2023

vishesh92 reviewed Oct 10, 2023

View reviewed changes

config/default/kustomization.yaml Show resolved Hide resolved

hrak force-pushed the tilt_metrics_fix branch from 6fa985f to 84fd02a Compare October 12, 2023 12:47

hrak added 3 commits November 8, 2023 15:20

Remove manager metrics patch

a06757d

This is done by cluster-api tilt-prepare now Signed-off-by: Hans Rakers <[email protected]>

Remove old credentials substition

9c9a7c9

+ add feature gate example Signed-off-by: Hans Rakers <[email protected]>

add explicit metrics bind addr arg that Tilt and e2e can replace

6009a1c

Signed-off-by: Hans Rakers <[email protected]>

hrak force-pushed the tilt_metrics_fix branch from 84fd02a to 6009a1c Compare November 24, 2023 12:28

hrak mentioned this pull request Dec 12, 2023

REQUEST: New membership for hrak kubernetes/org#4623

Closed

9 tasks

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 22, 2024

rohityadavcloud added this to the v0.5.0 milestone Mar 22, 2024

vishesh92 reviewed May 20, 2024

View reviewed changes

docs/book/src/development/tilt.md Show resolved Hide resolved

k8s-ci-robot assigned vishesh92 Jun 6, 2024

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 6, 2024

k8s-ci-robot merged commit c9f02ad into kubernetes-sigs:main Jun 6, 2024
9 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Tilt metrics fix + docs update #308

Tilt metrics fix + docs update #308

hrak commented Sep 1, 2023 •

edited

Loading

k8s-ci-robot commented Sep 1, 2023

netlify bot commented Sep 1, 2023 •

edited

Loading

rohityadavcloud commented Sep 20, 2023

blueorangutan commented Sep 20, 2023

codecov-commenter commented Sep 20, 2023

blueorangutan commented Oct 1, 2023

hrak commented Oct 2, 2023

vishesh92 commented Oct 10, 2023

blueorangutan commented Oct 10, 2023

vishesh92 commented Oct 10, 2023

k8s-ci-robot commented Oct 10, 2023

hrak commented Oct 12, 2023

weizhouapache commented Dec 6, 2023

blueorangutan commented Dec 6, 2023

rohityadavcloud commented Jan 3, 2024

blueorangutan commented Jan 3, 2024

rohityadavcloud commented Mar 22, 2024

weizhouapache commented May 28, 2024

blueorangutan commented May 28, 2024

vishesh92 commented Jun 6, 2024

blueorangutan commented Jun 6, 2024

blueorangutan commented Jun 6, 2024

vishesh92 commented Jun 6, 2024

Tilt metrics fix + docs update #308

Tilt metrics fix + docs update #308

Conversation

hrak commented Sep 1, 2023 • edited Loading

k8s-ci-robot commented Sep 1, 2023

netlify bot commented Sep 1, 2023 • edited Loading

✅ Deploy Preview for kubernetes-sigs-cluster-api-cloudstack ready!

rohityadavcloud commented Sep 20, 2023

blueorangutan commented Sep 20, 2023

codecov-commenter commented Sep 20, 2023

Codecov Report

blueorangutan commented Oct 1, 2023

hrak commented Oct 2, 2023

vishesh92 commented Oct 10, 2023

blueorangutan commented Oct 10, 2023

vishesh92 commented Oct 10, 2023

k8s-ci-robot commented Oct 10, 2023

hrak commented Oct 12, 2023

weizhouapache commented Dec 6, 2023

blueorangutan commented Dec 6, 2023

rohityadavcloud commented Jan 3, 2024

blueorangutan commented Jan 3, 2024

rohityadavcloud commented Mar 22, 2024

weizhouapache commented May 28, 2024

blueorangutan commented May 28, 2024

vishesh92 commented Jun 6, 2024

blueorangutan commented Jun 6, 2024

blueorangutan commented Jun 6, 2024

vishesh92 commented Jun 6, 2024

hrak commented Sep 1, 2023 •

edited

Loading

netlify bot commented Sep 1, 2023 •

edited

Loading